Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576591 --- Comment #10 from Terje RÃÂsten <terjeros@xxxxxxxxxxxx> 2011-01-26 04:53:34 EST --- Thanks, this is starting to look good. Some warnings from rpmlint: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) - convert tabs in Obsoletes: and Provides: to spaces. W: unversioned-explicit-obsoletes iptraf W self-obsoletion iptraf obsoletes iptraf = 1.0.3.52.gdaa1-1.fc14 - these seems dangerous, W: invalid-url Source0: https://fedorahosted.org/releases/i/p/iptraf-ng/iptraf-ng-1.0.3.52.gdaa1.tar.gz HTTP Error 404: Not Found - can't find the tarball on the website, would also be nice to remove the gdaa1 postfix. W: incoherent-version-in-changelog 1.0.2-3 ['1.0.3.52.gdaa1-1.fc14', '1.0.3.52.gdaa1-1'] - easy to fix W: manual-page-warning /usr/share/man/man8/iptraf-ng.8.gz 27: warning: macro `Biptraf' not defined Fix these and I will do the formal review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review