Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651898 --- Comment #4 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-01-26 03:52:43 EST --- I am taking over this package (right Jozef?). So here is updated package: Spec URL: http://people.redhat.com/vondruch/rubygem-activemodel.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-activemodel-3.0.3-1.fc14.src.rpm (In reply to comment #3) > rubygem-i18n has now made it into fedora and I've update rubygem-activesupport > to version 3.0.3 which will be pushed into fedora as soon as it's dependencies > are. > > For now use the following for this review > > http://mo.morsi.org/files/rpms/rubygem-activesupport-3.0.3-1.fc14.src.rpm > > * please update to latest activemodel upstream release, 3.0.3 DONE > * rpmlint looks good > > * mark README, LICENSE, CHANGELOG files as %doc DONE > * you do not need rm -rf %{buildroot} in %install and %clean sections (should > be removed) Removed from install section. Left in %clean section. If you remove it, then the activemode directory stays in BUILDROOT, which is not nice, although it doesn't make any problems. I should remember this and be consistent ... > * feel free to tar up upstream test suite and run in in a %check section DONE > * feel free to move docs into their own subpackage DONE I do not provide the Koji build due to missing activesupport dependency. However if approved, I can already prepare the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review