Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2006-12-11 19:03 EST ------- (In reply to comment #12) > Anyway leaving /etc/logrotate.d unowned by any pacakge is > wrong. You should either I don't disagree with you on that point. I was just pointing out that a discussion of how to to resolve this issue has not been finalized. > *for now* and my thought is this package (ntop) > should require logroate. Agreed. For now, this is the answer, but it may change in the future. > Leaving symlinks as they are is sufficient. Please check: > ------------------------------------------------------------------------- > [tasaka1@localhost ~]$ for f in /usr/lib/*/*.so ; do if [ -L $f ] ; then echo > $f ; fi ; done > ------------------------------------------------------------------------- > I don't think removing version info is a good idea. Because of the way the software works (it loads all files/links in the .../plugins directory), we can have either a versioned file (libnetflowPlugin-3.2.so) or unversioned (libnetflowPlugin.so). We can not have a symbolic link, because that would cause the plugin to load twice. Why do you think it's so important to keep the versioning? There are no dependencies on these files - they are dlopened by the application. > scriptlets like these need corresponding requirement as > Requires(post) or so. Please check the section "Services" of > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets Fixed. > By the way, is this okay? > xmldumpPlugin.c:53:2: warning: #warning Missing header files, disabling xmldump > plugin No, it just took me awhile to figure out the problem. Fixed now. Still the pid file is being written to /var/ntop although the config seems to indicate it should go elsewhere. Not sure why. Looking into that. Also, the syslog should be logged at facility=daemon. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review