Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=628665 Alexander Kurtakov <akurtako@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akurtako@xxxxxxxxxx --- Comment #6 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2011-01-25 18:43:27 EST --- Issues: * Version 4.1 is out. * As this is a gui application we need desktop file istalled as per http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files * setup not quiet - please add -q after the %setup call * mixed-use-of-spaces-and-tabs - please choose one and stick to it * package is pure java so it should be noarch this will prevent the empty debuginfo package problem too * wrong-file-end-of-line-encoding /usr/share/doc/Mars-4.0.1/MARSlicense.txt * class-class-path-in-manifest /usr/share/java/Mars.jarpath-in-manifest /usr/share/java/Mars.jar Sorry that this review is taking so long but we will get it in eventually. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review