Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #6 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-25 17:10:23 EST --- The first rpmlint message comes from the spell checker that can't find the en_US dictionary on your system. The warning unstripped-binary-or-object would need some attention. However, I can't reproduce it on my machine. Please bump the Release number every time you provide a new revision of the spec/srpm, and add a corresponding %changelog entry. Otherwise, it's hard to distinguish between the various versions. So your latest release is 2, the next one will be 3. - Please update the License field to "GPLv3+ and GFDL". The "+" refers to the text "or (at your option) any later version" in the comments of the source files. The documentation is licensed under GFDL (according to COPYING-DOCS). Also add a short comment above the License field that the executable is licensed under GPLv3+ and the docs under GFDL. - Drop %{_datadir}/locale/* from the %files section. - The directories below %{_datadir}/icons are still owned by the package because %{_datadir}/icons/* recursively adds all files and directories located in %{_datadir}/icons/. You must ensure that only the files are added. Thus, replace this line with %{_datadir}/icons/hicolor/*x*/apps/%{name}.png - when placing files below %{_datadir}/icons, you must update the icon cache: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review