[Bug 639874] Review Request: python-rocket - Modern, multi-threaded, comet-friendly WSGI web server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639874

--- Comment #6 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2011-01-25 16:26:35 EST ---
Note: In your Requires: section you have an:
%if 0%{?with_python3}
BuildRequires:  python3-setuptools
BuildRequires:  python3-devel
Requires: python3
%else
Requires: python
%endif

You actually want to change that a little bit.  The "Requires: python" should
be outside of the conditional since you want it to be a Requirement of the main
python-rocket package whether or not a python3 subpackage is built.  The
Requires: python3 portion should be part of the python3-rocket subpackage
further down in the spec file so that only the subpackage has a dependency on
python3.

BuildRequires stay at the top because one environment is setup for building all
of the subpackages.  So there's no need to parcel those out to each subpackage
section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]