[Bug 668090] Review Request: rubygem-railties - Rails internals: application bootup, plugins, generators, and rake tasks.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668090

--- Comment #6 from Minnikhanov <minnikhanov@xxxxxxxxx> 2011-01-25 14:36:50 EST ---
(In reply to comment #5)
> (In reply to comment #4)
Spec URL: http://dl.dropbox.com/u/14118661/rubygem-railties.spec
SRPM URL:
http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-4.fc14.src.rpm 

koji scratch build: green
http://koji.fedoraproject.org/koji/taskinfo?taskID=2742125 
TEST DON'T PASS. Not all gems packed.
Packages built.

> The first line of railties.gemspec is causing the issue:
> 
> version = File.read(File.expand_path("../../RAILS_VERSION", FILE)).strip
> 
> You can probably just add a patch swapping this line out with "version = 3.0.3"
>
+ Fixed. This was helpful.

> 
> 
> Usually if you have a %check section that runs a test suite, all the requires
> should be listed as BuildRequires as well, as the runtime dependencies are
> needed at build time. Thus rake, thor, activesupport, actionpack, etc should be
> BuildRequires as well.
> 
- Don't fixed completely yet. I will publish 'BuildRequires:' list for check at
next comment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]