Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pyscript - Postscript graphics with Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219119 ------- Additional Comments From mr.ecik@xxxxxxxxx 2006-12-11 13:15 EST ------- MUST items: !* rpmlint output: W: pyscript macro-in-%changelog python_sitelib W: pyscript macro-in-%changelog ghost W: pyscript macro-in-%changelog __python W: pyscript macro-in-%changelog _libdir E: pyscript no-binary E: pyscript-debuginfo empty-debuginfo-package * package is named well * spec file name is good * package meets Packaging Guidelines * package is licensed with a GPL open-source compatible license * License field in spec file matches actual license * license file is included in %doc * md5sums are matching (8b4945fda4318abdcd77f1573996b9da) * package successfully compiles on x86_64 * BuildRequires listed well * no locales * no need to %post and %postun sections * not relocatable * package owns directories well * no duplicates in %files * %files section includes %defattr * proper %clean section * macros used well THINGS to do: * get rid of all macro-in-%changelog rpmlint warnings by doubling all % characters in %changelog. For example: instead of %{_libdir} write %%{_libdir} * fix no-binary and debuginfo package problems by adding BuildArch: noarch to preamble * from my experience I know that using python-devel BR instead of python is better solution * do we really need tetex package? I have grepped all the sources and I found that pyscript needs only latex application which is part of tetex-latex package. Thus I believe that it is a dependency we really need. Correct me if I am wrong. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review