Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650667 --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-24 17:55:37 EST --- Hi Mario, here are some initial comments on your package: - please choose a Summary that doesn't repeat the package name, e.g. something like "Logical number puzzle game for Gnome" - change the Group to Amusements/Games - according to the source file headers, the license is GPLv3+ - Source0 should contain a complete URL pointing to the upstream tarball - drop Requires: gtk because it's picked up automatically as a dependency - the package doesn't build in mock because of missing BuildRequires: intltool gnome-doc-utils - The %description lines should not exceed 80 characters per line. Just split them. - see here how to install the locales properly: https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files - see here how to install the desktop file properly: https://fedoraproject.org/wiki/Packaging/Guidelines#desktop - Your package currently owns the directory /usr/share/icons/hicolor (and the folders below). These folders are already owned by package hicolor-icon-theme. Thus, add hicolor-icon-theme package as a dependency and only add the image files in %files. - add the release number to the version in the %changelog headers: 0.2.5-1 $ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm hitori.src: W: name-repeated-in-summary C Hitori hitori.src: E: description-line-too-long C Hitori is a small application written to allow one to play the eponymous puzzle game, which is similar in theme to more popular puzzles such as Sudoku. hitori.src: E: description-line-too-long C It depends on GTK+ 2.13 and Cairo 1.4, and has full support for playing the game (i.e. it checks all three rules are satisfied). It has undo/redo support, can give hints, and allows for cells to be tagged with one of two different tags, to aid in solving the puzzle. It has support for anything from 5Ã5 to 10Ã10 grids. hitori.src: W: non-standard-group Games hitori.src: W: invalid-url Source0: hitori-0.2.5.tar.bz2 hitori.x86_64: W: name-repeated-in-summary C Hitori hitori.x86_64: E: description-line-too-long C Hitori is a small application written to allow one to play the eponymous puzzle game, which is similar in theme to more popular puzzles such as Sudoku. hitori.x86_64: E: description-line-too-long C It depends on GTK+ 2.13 and Cairo 1.4, and has full support for playing the game (i.e. it checks all three rules are satisfied). It has undo/redo support, can give hints, and allows for cells to be tagged with one of two different tags, to aid in solving the puzzle. It has support for anything from 5Ã5 to 10Ã10 grids. hitori.x86_64: W: non-standard-group Games hitori.x86_64: W: incoherent-version-in-changelog 0.2.5 ['0.2.5-1.fc14', '0.2.5-1'] hitori.x86_64: W: no-manual-page-for-binary hitori hitori.x86_64: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/da/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/el/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/en_GB/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/id/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/nb/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/pa/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/sl/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/sv/LC_MESSAGES/hitori.mo hitori.x86_64: W: file-not-in-%lang /usr/share/locale/zh_CN/LC_MESSAGES/hitori.mo 3 packages and 0 specfiles checked; 4 errors, 23 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review