Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518546 --- Comment #73 from Peter Robinson <pbrobinson@xxxxxxxxx> 2011-01-24 06:38:08 EST --- In the 1.0.7 update it looks like the intel i965 wasn't completely stripped. The directory is still there although the configure/Makefile looks OK. Other than that there's just the rpmlint error below. The rest looks OK to me. - rpmlint output E: useless-provides libva-devel I presume that's suppose to obsolete libva-freeworld and libva-freeworld-devel from rpmfusion rpmlint libva-1.0.7-1.fc15.src.rpm libva-1.0.7-1.fc15.x86_64.rpm libva-devel-1.0.7-1.fc15.x86_64.rpm libva.spec libva.src:16: W: macro-in-comment %{version} libva.src: W: invalid-url Source0: libva-1.0.7-mod.tar.bz2 libva.x86_64: W: no-manual-page-for-binary vainfo libva-devel.x86_64: E: useless-provides libva-devel libva-devel.x86_64: W: no-documentation libva.spec:16: W: macro-in-comment %{version} libva.spec: W: invalid-url Source0: libva-1.0.7-mod.tar.bz2 3 packages and 1 specfiles checked; 1 errors, 6 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged 1.0.7 + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 3903b0463e2892f8afbd631daa5619ae libva-1.0.7.tar.bz2 (original) this seems OK based on my checking of the process documented in the .spec + package successfully builds on at least one architecture tested using koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2738557 + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* + binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates n/a no duplicate files in %files + Package perserves timestamps on install + Permissions on files must be set properly + %defattr line + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime + header files should be in -devel n/a static libraries should be in -static + packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' + libfoo.so must go in -devel + devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: + if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji + the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a non -devel packages should require fully versioned base + pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin ? Package should have man files Not a big problem -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review