Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668090 --- Comment #3 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2011-01-23 17:40:23 EST --- (In reply to comment #2) > Spec URL: http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-2.fc14.spec > SRPM URL: > http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-2.fc14.src.rpm > > koji scratch build: FAIL > http://koji.fedoraproject.org/koji/taskinfo?taskID=2738446 > root.log > >>> > DEBUG backend.py:745: /usr/bin/yum-builddep --installroot > /var/lib/mock/dist-f15-build-964373-145195/root/ > '/var/lib/mock/dist-f15-build-964373-145195/root///builddir/build/SRPMS/rubygem-railties-3.0.3-2.fc15.src.rpm' > DEBUG util.py:281: Executing command: /usr/bin/yum-builddep --installroot > /var/lib/mock/dist-f15-build-964373-145195/root/ > '/var/lib/mock/dist-f15-build-964373-145195/root///builddir/build/SRPMS/rubygem-railties-3.0.3-2.fc15.src.rpm' > DEBUG util.py:247: Getting requirements for rubygem-railties-3.0.3-2.fc15.src > DEBUG util.py:247: --> rubygems-1.3.7-2.fc14.noarch > DEBUG util.py:247: --> ruby-libs-1.8.7.330-2.fc15.x86_64 > DEBUG util.py:247: Error: No Package found for rubygem(date) > DEBUG util.py:320: Child returncode was: 1 > <<< > > (In reply to comment #1) date isn't a rubygem. Its part of the ruby standard library. Same with rbconfig. See /usr/lib/ruby/1.8/date.rb /usr/lib/ruby/1.8/i386-linux/rbconfig.rb > > > > rubygem-railties-doc.noarch: E: script-without-shebang > > /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/guides/assets/stylesheets/syntaxhighlighter/shThemeMDUltra.css > > > > This stylesheet seems to be mistakingly marked as executable in the upstream > > source, can prolly chmod it to remove the executable permission > > > + Fixed in %prep. Thanks alot. The find command doing so isn't just right though. Running it, I get "find: missing argument to `-exec'" To fix this append "{} \;" to the end of the find command like so: find ./%{geminstdir} -name *.css -type f -perm /a+x -exec chmod -v 644 {} \; > > > rubygem-railties.noarch: W: hidden-file-or-dir > > /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/lib/rails/generators/rails/app/templates/test/fixtures/.empty_directory > > rubygem-railties.noarch: E: zero-length > > /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/lib/rails/generators/rails/app/templates/test/fixtures/.empty_directory > > > > There are a bunch of these errors for various .empty_directory files in the > > railties gem, these need to be included in the project correct? > > > I delete these files in %prep. (??? - my opinion). > I guess its need for generator as some mark. I look at source. > No empty folder here lib/rails/generators/rails/app/templates/* > This need addition info. > They do seem to be in the upstream source, see for example https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/generator/templates/templates/.empty_directory It might not be a bad idea to lean on the safe side and leave them included. Or at the very least, ensure the test suite works w/ those files removed. > > * rm -rf %{buildroot} at the beginning of %install isn't needed and should be > > removed > + Fixed. Thanks alot > > > * Feel free to tar up the upstream test suite for the 3.0.3 railties release > > and run it in a %check section in the rpm > > > + Make %check section. > Rakefile: > >>> > require 'rake' > require 'rake/testtask' > require 'rake/gempackagetask' > > require 'date' > require 'rbconfig' > <<< > Make > BuildRequires: rubygem(date) > BuildRequires: rubygem(rbconfig) > > rubygem-date didn't pack. Again, date and rbconfig aren't rubygems, and are covered w/ the existing BuildRequires. Running the test suite works as is (I tried it out). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review