Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551411 Peter Robinson <pbrobinson@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #9 from Peter Robinson <pbrobinson@xxxxxxxxx> 2011-01-23 10:26:14 EST --- All looks fine. A few minor things that you might want to consider: - spelling note in rpmlint as customizations doesn't need the s - CFLAGS="$RPM_OPT_FLAGS" is superfluous as its automatically added by the rpmbuild process - A man page would be a nice additions. + rpmlint output $ rpmlint olpc-os-builder.spec olpc-os-builder-3.0.0-0.1.pre1.fc15.src.rpm olpc-os-builder-3.0.0-0.1.pre1.fc15.x86_64.rpm olpc-os-builder.src: W: spelling-error %description -l en_US customizations -> customization, customization's, customization s olpc-os-builder.x86_64: W: spelling-error %description -l en_US customizations -> customization, customization's, customization s olpc-os-builder.x86_64: W: no-manual-page-for-binary olpc-os-builder 2 packages and 1 specfiles checked; 0 errors, 3 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm c03c72996bb1ea5faadc7d4bb7cc7f8d olpc-os-builder-3.0.0_pre1.tar.bz2 + package successfully builds on at least one architecture tested using koji scratch build + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates n/a no duplicate files in %files + Package perserves timestamps on install + Permissions on files must be set properly + %defattr line + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: + if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji n/a the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a non -devel packages should require fully versioned base n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin - Package should have man files APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review