Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670999 --- Comment #5 from Michal Ingeli <mi@xxxxx> 2011-01-23 05:05:35 EST --- (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Yes, it does. But except the perl(Class::Method::Modifiers), so I left that one > > there. > > Hmm, INSTALL and META.yml say this module would require > Class::Method::Modifiers, but I can't spot any place inside of run-time part of > this perl module, which actually requires it: > > # grep -R Class::Method::Modifiers MongoDB-0.41 > MongoDB-0.41/Makefile.PL:requires 'Class::Method::Modifiers'; > MongoDB-0.41/META.yml: Class::Method::Modifiers: 0 > MongoDB-0.41/INSTALL: sudo cpan Class::Method::Modifiers The comment in Makefile.PL says: # C::M::Modifiers isn't always needed. It'll be used only if Any::Moose decides # to use Mouse instead of Moose. We depend on it anyway to make sure it's there # when it's needed. requires 'Class::Method::Modifiers'; The Any::Moose, Moose, nor Mouse seems to require this package at runtime. Package builds without it, and test phase passes. It should be safe to remove this. > Besides this, package does not build in mock: > ... > error: line 1: Unknown tag: %perl_default_filter Added condition for this macro. Now it builds in mock. I additionally added Try::Tiny, as it is needed for tests. The test phase will be skipped at normal mock build, because we cannot have mongod running. But one can run them locally. rpms: http://v3.sk/~xyzz/rpm/perl-MongoDB-0.41-3.fc14.src.rpm spec: http://v3.sk/~xyzz/rpm/perl-MongoDB.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review