Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #22 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2011-01-21 17:17:18 EST --- (In reply to comment #21) > TODO: With respect to deb/control and modules/core.py, this package depends on > 7za, so please add /usr/bin/7za to requirement. I said this earlier. Indeed, you said this earlier, but I missed it due to the high number of comments. I don't want to be impolite or sound ungrateful, but I would rather prefer a *full* review instead of new pitfalls with every comment. I think this would be easier and less time consuming for both me and you. > TODO: %{_datadir}/application-registry/%{name}.applications and > %{_datadir}/mime-info/%{name}.* are redundant and should be excluded. Just > %{_datadir}/mime/packages/%{name}.xml and > %{_datadir}/applications/%{name}.desktop are useful with the current xdg > mimetype mechanism. I agree that %{_datadir}/application-registry/ seems to be dead, but can we really be sure all applications in Fedora are using shared-mime-info? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review