Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663102 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #9 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2011-01-20 13:24:17 EST --- This is quite a clean package. It builds fine and rpmlint is silent. You can remove BuildRoot, %clean and the first line of %install. You're obviously not targeting el4 or el5 with this spec (because of the filter stuff) so you shouldn't need those bits either. I found a few files which do not appear to have the same license. smartcard/ClassLoader.py taken from the Python Cookbook. The provided URL indicates the "psf" license which I believe we call "Python", but I'm not certain. smartcard/Observer.py smartcard/Synchronization.py taken from http://mindview.net/Books/TIPython; I didn't see a license at first glance. smartcard/scard/pyscard-reader.h - I think this is BSD license, but you'll need to chase down the source of the code and verify. In any case, as it is compiled in with LGPL code it shouldn't change the final license but you must still verify that it is licensed and that license is compatible. * source files match upstream. sha256sum: 0f70f8dd909497183bc1446fe7ea8b4498c7d1516269200f90cd0eec1fa6d630 pyscard-1.6.12.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. ? license field matches the actual license. ? license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: pyscard-1.6.12-3.fc15.x86_64.rpm pyscard = 1.6.12-3.fc15 pyscard(x86-64) = 1.6.12-3.fc15 = pcsc-lite libpython2.7.so.1.0()(64bit) python(abi) = 2.7 * no bundled libraries that I can find. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no static libraries. * no libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review