Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671079 --- Comment #1 from Ondrej Vasik <ovasik@xxxxxxxxxx> 2011-01-20 09:17:52 EST --- First iteration of review: please, use %global instead of %define macros - see https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define you could drop BuildRoot, it is no longer necessary... comment about Patch4 but no Patch4 ... cleanup neeeded? I see only AUTHORS COPYING and README - why you don't use %doc macro for them? It would give user a chance to install rpm without documentation. .c/.h files in srpm have strange permissions 755. Have you considered -devel subpackage? Or it is not expected someone except IBM could use the API for development? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review