Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-12-10 07:28 EST ------- Well, a quick glance at this package: * some files should not be in main package, like: -------------------------------------------------- W: ntop devel-file-in-non-devel-package /usr/lib/libntop.so -------------------------------------------------- * permissions of some files in -debug package is wrong. ---------------------------------------------------- E: ntop-debuginfo script-without-shebang /usr/src/debug/ntop-3.2/fcUtils.c E: ntop-debuginfo script-without-shebang /usr/src/debug/ntop-3.2/plugins/xmldumpPlugin.c E: ntop-debuginfo script-without-shebang /usr/src/debug/ntop-3.2/globals-structtypes.h ------------------------------------------------------ * By the way, what is fedora-groupadd? Is there any reason that this cannot be replaced with groupadd? * Usually calling userdel or groupdel is not recommended. Usually it is left as it is and deleting user or group should be manually done by administrator. * For Requires: Please don't write the explicit dependency which is required automatically by dependencies of libraries. For example, libgd.so.2 dependency pulls gd, so adding "gd" explicitly to Requires is not needed. * For BuildRequires: Please don't write redundant dependencies. For example, zlib-devel is required by openssl-devel, so adding "zlib-devel" to BuildRequires is not necessary. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review