Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663244 --- Comment #9 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-20 04:30:43 EST --- (In reply to comment #7) > Thanks for your wondeful feedback! You're welcome. :) > I haven't changed Source0 because I get a 404 error if I use Source0 as: > http://downloads.sourceforge.net/%{name}/%{name}-2.1-2-src.tar.bz2 This is because upstream doesn't use camel case in the sourceforge project name. http://downloads.sourceforge.net/cunit/%{name}-2.1-2-src.tar.bz2 should work. > I have pushed the patches upstream for inclusion in the project repo, and > retaining it in the .spec file since rpmlint warns about calling exit() > function in a library. OK, but please don't apply the exit() patch. The rpmlint warning should encourage you to convince the upstream developer to fix the issue. But don't do it yourself with a local patch because it changes the behavior of the library. I also suggest to ask upstream what's the intention of the dash in the version number. Does the versioning scheme always follow pattern A.B-C or could there also be an A.B.C-D release? If A.B-C is guaranteed, I recommend to replace the dash with a dot in the Fedora package (rather than an underscore). Maybe upstream should also think about using only dots as separators. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review