Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gaim-libnotify - Libnotify Gaim plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219050 ------- Additional Comments From peter@xxxxxxxxxxxxxxxx 2006-12-10 03:15 EST ------- (In reply to comment #2) > [root@localhost mock]# rpmlint gaim-libnotify > E: gaim-libnotify description-line-too-long gaim-libnotify is a plugin for the > open-source Gaim instant messaging client that > [root@localhost mock]# rpmlint gaim-libnotify > E: gaim-libnotify description-line-too-long gaim-libnotify is a plugin for the > open-source Gaim instant messaging client that > [root@localhost mock]# rpmlint -I description-line-too-long > description-line-too-long : > Your description lines must not exceed 79 characters. If a line is exceeding > this number, cut it to fit in two lines. Gaah I didn't see that expansion of the %name macro would push it past this limit. I've fixed this in release 2 (0.12-2). * File and Directory Ownership > - /usr/lib/gaim > This directory is not owned by any package required by this > rpm. This package should need gaim as Requires. Thanks for catching that. Fixed in 0.12-2 > * BuildRequires > - Why does this package need > gettext perl-XML-Parser > as BuildRequires? Mockbuild for FC-devel i386 is fine without > these two packages. I put those in as the first ones in the spec mostly of habit when I saw that gettext was being used for the translation foo, but then forgot to test whether or not they were actually needed. >_> Thanks for checking this; and they're gone in 0.12-2. Spec: http://thecodergeek.com/downloads/fedora/gaim-libnotify.spec Source RPM: http://thecodergeek.com/downloads/fedora/gaim-libnotify-0.12-2.src.rpm Thanks for your time. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review