Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670302 --- Comment #4 from Matthew Garrett <mjg@xxxxxxxxxx> 2011-01-18 23:04:11 EST --- > libbacklight.c:81:2: warning: implicit declaration of function 'strtol' Fixed > libbacklight.h lacks a "header inclusion guard" Added > Still no legal information in libbacklight.h (no copyright/license). I don't think there's anything substantively copyrightable in the file, but the project copyright file included in %doc. > libbacklight.h includes <pciaccess.h> It's needed for struct pci_device, but the missing Requires was a bug. Spec URL: http://www.codon.org.uk/~mjg59/tmp/libbacklight/libbacklight.spec SRPM URL: http://www.codon.org.uk/~mjg59/tmp/libbacklight/libbacklight-0.01-2.fc15.src.rpm Thanks for the feedback! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review