Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619228 --- Comment #6 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-18 18:01:45 EST --- Jochen, here are some more things to consider: - add "daemon" before $exec in function start() of the initscript - the daemon should not be started automatically after installation, see http://fedoraproject.org/wiki/Packaging/SysVInitScript#Why_don.27t_we.... - add the missing %post and %postun scriptlets: http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets - /usr/sbin/shellinaboxd allows executable code on the stack. I'm not sure if this is really necessary. Please ask upstream whether shellinaboxd actually requires this feature. If not, disable stack execution using execstack -c. $ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm shellinabox.src: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging shellinabox.src: W: strange-permission shellinabox.init 0755L shellinabox.src: W: invalid-url Source0: http://shellinabox.googlecode.com/files/shellinabox-2.10.tar.gz HTTP Error 404: Not Found shellinabox.x86_64: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging shellinabox.x86_64: W: executable-stack /usr/sbin/shellinaboxd shellinabox.x86_64: E: zero-length /usr/share/doc/shellinabox-2.10/demo/usercss-1.css shellinabox.x86_64: E: zero-length /usr/share/doc/shellinabox-2.10/black-on-white.css shellinabox.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/shellinaboxd shellinabox.x86_64: W: service-default-enabled /etc/rc.d/init.d/shellinaboxd shellinabox.x86_64: W: incoherent-subsys /etc/rc.d/init.d/shellinaboxd $prog shellinabox.x86_64: W: service-default-enabled /etc/rc.d/init.d/shellinaboxd 3 packages and 0 specfiles checked; 3 errors, 8 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review