[Bug 665995] Review Request: fmit - Free Music Instrument Tuner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665995

--- Comment #16 from Volker FrÃhlich <volker27@xxxxxx> 2011-01-17 13:38:33 EST ---
[+] Good
[X] Needs work
[0] Does not apply

MUST:
=====

[+] rpmlint:

fmit.x86_64: W: spelling-error %description -l en_US formants -> formant,
formats, form ants
fmit.x86_64: W: no-manual-page-for-binary fmit
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

[+] Naming according to the Package Naming Guidelines
[+] Spec file matches base package name
[X] Packaging guidelines met

Preserve timestamps:

install -Dpm 0644 %{SOURCE1} %{buildroot}%{_datadir}/pixmaps/%{name}.png

[+] License approved for Fedora
[X] License field in spec matches

See comment 12

[+] License included, if source package includes it
[+] Spec in American English
[+] Spec is legible
[+] Sources match upstream md5sum: 707f062542cef1f3176d347c4f594b52
[+] Compiles and builds into binary RPMs on at least one primary architecture:
[0] ExcludeArch is specified and commented
[0] Locales are handled correctly
[+] All build dependencies listed
[0] Calls ldconfig for its shared libraries
[+] No bundled system libraries
[0] Stated as relocatable package
[+] Owns all its directories or requires package that does
[+] No file listing duplicates
[+] File permissions correct
[+] Consistent use of macros
[+] Code or permissable content
[0] Large documentation in -doc subpackage
[+] No runtime dependency of files listed as %doc
[0] Header files in -devel subpackage
[0] Static files in -static subpackage
[0] Library files without suffix in -devel subpackage
[0] Devel-package requires base package
[0] No .la libtool archives
[+] GUI application includes properly installed %{name}.desktop file
[+] No files or directories owned, that other packages own
[+] Filenames in packages are UTF-8

SHOULD:
=======

[0] Query upstream if no license text is included
[+] Package builds in mock
[X] Package works as described

See comment at the bottom!

[0] Scriptlets are sane, if used
[0] Subpackages other than -devel should require base package (versioned)
[0] pkgconfig files in -devel subpackage
[0] Dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider
requiring the package which provides the file instead of the file itself
[0] Contain man pages, where they make sense

COMMENT:
========

Patching to "default" seems mandatory, since I can reproduce a crash otherwise:

.) Start FMIT
.) Configure --> Change "hw:0" to "default"
.) Working fine
.) Open configuration dialog again
.) Crash

NO MUST:
=======

Remove "VERBOSE=1", since it is the default for %cmake.

Did you put "Music Instrument Tuner" instead of "Free Music Instrument Tuner"
in the desktop file on purpose

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]