Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2011-01-17 11:11:29 EST --- Just some quick comments: - You are mixing %{buildroot} and $RPM_BUILD_ROOT - All doc files (README, NEWS, etc) should go to %doc - 'desktop-file-install' is not used https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - Isn't RPM picking the gobject-introspection dependency automatically? - The icon cache update is missing. https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review