Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670090 Daiki Ueno <dueno@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dueno@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dueno@xxxxxxxxxx --- Comment #3 from Daiki Ueno <dueno@xxxxxxxxxx> 2011-01-17 03:59:28 EST --- I'm trying to review. - rpmlint reports several errors and warnings with binary RPMs bicon.x86_64: E: standard-dir-owned-by-package /usr/share/man bicon.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1 Please exclude those directories from %files. bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/README 0600L bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/COPYING 0600L bicon.x86_64: E: non-readable /usr/share/doc/bicon-0.2.0/AUTHORS 0600L Please give proper permissions to %docs. bicon.x86_64: W: devel-file-in-non-devel-package /usr/lib64/bicon/libbjoining.so bicon.x86_64: W: devel-file-in-non-devel-package /usr/lib64/bicon/libbconsole.so Please exclude those symlinks from the base package. - it would be nice to preserve timestamps when install. https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps Consider using something like: make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install - you can drop BuildRoot stuff https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag - consider having a separate package for fonts https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fonts_in_other_packages I think this might not apply since the package contains only 4 fonts and each of them is about 4KB, but if you plan to subpackage them, you could check terminus-fonts-console. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review