Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Image-Canvas - Common interface to image drawing Alias: pear-Image-Canvas https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218230 ------- Additional Comments From Fedora@xxxxxxxxxxxxxxxxx 2006-12-09 01:55 EST ------- Tests works. Example doesn't because it's use MS Windows Fonts. REVIEW * source files match upstream: 41dd36fb05436159fb6fccca02cb7aaa /tmp/Image_Canvas-0.3.0.tgz 41dd36fb05436159fb6fccca02cb7aaa ../SOURCES/Image_Canvas-0.3.0.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible (LGPL). * latest version is being packaged (0.3.0) * BuildRequires are proper. * %clean is present. * package builds in mock (development). * package installs properly * rpmlint is silent. * final provides are sane: php-pear(Image_Canvas) = 0.3.0 php-pear-Image-Canvas = 0.3.0-2.fc7 * final Requires are sane: php-pear(Image_Color) -> php-gd * %check is not present; * owns the directories it creates => own directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear install) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. MUST : - not own /usr/share/pear/Image which is owned by php-pear-Image-Color (required , remplace with %file /usr/share/pear/Image/Canvas* SHOULD : - also remove /usr/share/pear/test/Image_Canvas/tests/pdf.php - add a information (in description or a README.fedora) about "PDF not available" -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review