Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=669644 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |iarnell@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |iarnell@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> 2011-01-16 03:30:48 EST --- + source files match upstream. 445166a7472e609b96e4474d95552827 Test-Inter-1.01.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. (but needs a space after the period in 3rd line) + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text included. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2720826 + package installs properly. + rpmlint has no complaints: 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: perl(Test::Inter) = 1.01 perl-Test-Inter = 1.01-1.fc15 = perl >= 0:5.004 perl(File::Basename) perl(File::Basename) perl(IO::File) perl(IO::File) perl(:MODULE_COMPAT_5.12.2) perl(strict) perl(vars) perl(warnings) + %check is present and all tests pass. + ./Build test t/file.t .......... ok t/is.t ............ ok t/ok.t ............ ok t/pod.t ........... ok t/pod_coverage.t .. ok t/require_ok.t .... ok t/skip_all.t ...... skipped: testing skip_all t/tests.t ......... ok t/use_ok.1.t ...... ok t/use_ok.2.t ...... ok t/use_ok.3.t ...... ok All tests successful. Files=11, Tests=60, 0 wallclock secs ( 0.03 usr 0.02 sys + 0.34 cusr 0.06 csys = 0.45 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. There's a space missing after the period in 3rd line of %description. And the explicit Requires for perl(File::Basename) and perl(IO::File) are unnecessary - both are detected automatically. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review