Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666301 --- Comment #7 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2011-01-15 12:46:01 EST --- Further remarks: MUSTFIXES: * The *.pc is broken: ... libdir=/usr//usr/lib64 ... A detail, I am not sure about how pkgconfig will handle it, is the version number: Version: 1.6.0b4 * AFAICT, several "Requires:" are missing from *-devel. E.g. libstdc++-devel (package uses libstdc++ headers) * Some of the headers contain questionable defines: # grep -R HAVE_ usr/include/* usr/include/liblas/transform.hpp:#ifdef HAVE_GDAL usr/include/liblas/transform.hpp:#ifdef HAVE_GDAL usr/include/liblas/transform.hpp:#ifdef HAVE_GDAL usr/include/liblas/detail/reader/zipreader.hpp:#ifdef HAVE_LASZIP usr/include/liblas/detail/reader/zipreader.hpp:#endif // HAVE_LASZIP usr/include/liblas/detail/zippoint.hpp:#ifdef HAVE_LASZIP usr/include/liblas/detail/zippoint.hpp:#endif // HAVE_LASZIP usr/include/liblas/detail/writer/zipwriter.hpp:#ifdef HAVE_LASZIP usr/include/liblas/detail/writer/zipwriter.hpp:#endif // HAVE_LASZIP - These defines collide with autoconf defines. A proper way to fix this to append such defines with a package specific prefix (e.g. _LIBLAS ...) and to let the package generate a header file providing these defines + to let all files using these defines include it. - liblas need to defined/undefine these defines. Otherwise applications using this library are at risk of using a different API/ABI than the library. Though this occasionally may make sense, I doubt this is intentional. SHOULD/CONSIDER: * Finally, the tarball name being used is causing me headaches, but I am not familiar with mercurial and don't know off-head what the FPG says. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review