Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651101 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-15 09:26:37 EST --- Hi Sergio, the package looks almost fine. Just a couple of minor notes: - drop %{_mandir}/manx/psfex.x from the package as psfex.x doesn't contain any useful information (and directory %{_mandir}/manx is unowned). - be more explicit in %files especially when adding only single files: %{_bindir}/* => %{_bindir}/%{name} %{_mandir}/man1/* => %{_mandir}/man1/%{name}.1* - drop empty file BUGS from %doc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review