Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652585 Lakshmi Narasimhan <lakshminaras2002@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(lemenkov@xxxxxxxx | |m) --- Comment #3 from Lakshmi Narasimhan <lakshminaras2002@xxxxxxxxx> 2011-01-15 02:00:38 EST --- [+]MUST: rpmlint must be run on every package. The output should be posted in the review. rpmlint -i erlang-luke.spec erlang-luke-0.2.3-1.fc14.*.rpm erlang-luke.spec: W: invalid-url Source0: basho-luke-luke-0.2.3-0-gce91e00.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. erlang-luke.src: W: spelling-error Summary(en_US) Dataflow -> Data flow, Data-flow, Dayflower The value of this tag appears to be misspelled. Please double-check. erlang-luke.src: W: spelling-error %description -l en_US Dataflow -> Data flow, Data-flow, Dayflower The value of this tag appears to be misspelled. Please double-check. erlang-luke.src: W: invalid-url Source0: basho-luke-luke-0.2.3-0-gce91e00.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. erlang-luke.x86_64: E: explicit-lib-dependency erlang-stdlib You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. erlang-luke.x86_64: W: spelling-error Summary(en_US) Dataflow -> Data flow, Data-flow, Dayflower The value of this tag appears to be misspelled. Please double-check. erlang-luke.x86_64: W: spelling-error %description -l en_US Dataflow -> Data flow, Data-flow, Dayflower The value of this tag appears to be misspelled. Please double-check. erlang-luke.x86_64: E: no-binary - The package should be of the noarch architecture because it doesn't contain any binaries. erlang-luke.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. erlang-luke.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. 2 packages and 1 specfiles checked; 2 errors, 8 warnings. [+]MUST: The package must be named according to the Package Naming Guidelines. [+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec [+]MUST: The package must meet the Packaging Guidelines. Naming-Yes Version-release - Matches License - OK, Apache license 2.0 No prebuilt external bits - OK, prebuilt binary is present in the source package to be used for building. However its not shipped with the rpm Spec legibity - OK. Package template - OK Arch support - OK, No specific exclusive arch or exclude arch Libexecdir - OK, not used rpmlint - yes changelogs - OK Source url tag - Not present(commented out). https://nodeload.github.com/basho/luke/tarball/luke-0.2.3 looks to be usable with wget Buildroot is ignored - present anyway. http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo %clean is ignored - present anyway. OK Build Requires list - OK Summary and description - OK API documentation - No documentation. [+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. Licensed with Apache License 2.0. Both source and test files have Apache license text. [+]MUST: The License field in the package spec file must match the actual license. [NA]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. No separate LICENSE file present. [+]MUST: The spec file must be written in American English. [+]MUST: The spec file for the package MUST be legible. [+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task. md5sum basho-luke-luke-0.2.3-0-gce91e00.tar.gz 6b0eeeb360109ee5ad58959b82327a94 basho-luke-luke-0.2.3-0-gce91e00.tar.gz md5sum erlang-luke-0.2.3-1.fc12.src/basho-luke-luke-0.2.3-0-gce91e00.tar.gz 6b0eeeb360109ee5ad58959b82327a94 erlang-luke-0.2.3-1.fc12.src/basho-luke-luke-0.2.3-0-gce91e00.tar.gz [+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. Built on x86_64 [+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. No exclusive/exclude arch provided. [+]MUST: All build dependencies must be listed in BuildRequires. Verified by koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=2722532 [NA]MUST: The spec file MUST handle locales properly using the %find_lang macro [NA]MUST: Packages stores shared library files must call ldconfig in %post and %postun. [+]MUST: Packages must NOT bundle copies of system libraries. Checked with rpqmquery --list [NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. [+]MUST: A package must own all directories that it creates. Checked with rpmquery --whatprovides [+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [+]MUST: Permissions on files must be set properly. Checked with ls -lR [+]MUST: Each package must consistently use macros. [+]MUST: The package must contain code, or permissable content. [NA]MUST: Large documentation files must go in a -doc subpackage. [NA]MUST: If a package includes something as %doc, it must not affect the runtime of the application. No doc [+]MUST: Header files must be in a -devel package. No header files [NA]MUST: Static libraries must be in a -static package. [NA]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [NA]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release} No devel package [NA]MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section [+]MUST: Packages must not own files or directories already owned by other packages. [+]MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+]MUST: All filenames in rpm packages must be valid UTF-8. Should items [-]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [+]SHOULD: The reviewer should test that the package functions as described. Installed the package. Installs fine. [+]SHOULD: If scriptlets are used, those scriptlets must be sane. Comments I did find this URL to be usable https://nodeload.github.com/basho/luke/tarball/luke-0.2.3 (worked with wget). I am not aware of any limitation in using this. Please let me know if there would be issues using this URL in the spec file. The stdlib warning is based on textual match. False positive, in my opinion. If the files inside ebin are object files(something like .o?), then placing them lib directory would be appropriate No exclusive or exclude arch provided. So I am assuming that erlang is available on all architectures supported by Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review