Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667226 --- Comment #6 from Volker FrÃhlich <volker27@xxxxxx> 2011-01-13 21:57:10 EST --- You forgot to make a changelog entry. The changelog should reflect the changes made to the spec file. You can avoid this and other glitches by running rpmlint on your spec file or src.rpm. That would have also saved you from this one: %{_datadir}/share/tepsonic --> %{_datadir}/%{name} Taking a look at desktop files with desktop-file-validate, the categories list doesn't end in a semicolon. sed -i 's/\(^Categories.*\)/\1;/g' %{name}.desktop %{_prefix}/share/ --> %{_datadir} Please use rm -f or rm -rf instead of the rm macro. Please patch CMakeLists.txt for qxt. If Fedora shipped a new version of qxt, it could be break. Please align "qt-mysql". It now uses a tabulator. The license is still stated as GPLv3, although the files say GPLv3+. Please also take a look at http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review