Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539693 --- Comment #3 from Thibault North <thibault.north@xxxxxxxxx> 2011-01-13 19:29:35 EST --- Initial comments: - Strange indentation (unaligned lines) - Result of rpmlint is not clean: [tnorth@grouchy ~]$ rpmlint /home/tnorth/rpmbuild/SRPMS/plowshare-0.8.1-1.fc14.src.rpm /home/tnorth/rpmbuild/RPMS/noarch/plowshare-0.8.1-1.fc14.noarch.rpm plowshare.src: W: spelling-error Summary(en_US) downloader -> downloaded, down loader, down-loader plowshare.src: W: spelling-error Summary(en_US) uploader -> unloader, uploaded, up loader plowshare.src: W: summary-not-capitalized C command-line downloader/uploader for some of the most popular file-sharing websites plowshare.src: E: summary-too-long C command-line downloader/uploader for some of the most popular file-sharing websites plowshare.src: I: enchant-dictionary-not-found ru plowshare.src: W: spelling-error %description -l en_US downloader -> downloaded, down loader, down-loader plowshare.src: W: spelling-error %description -l en_US uploader -> unloader, uploaded, up loader plowshare.src: W: invalid-url Source0: http://plowshare.googlecode.com/files/plowshare-0.8.1.tgz HTTP Error 404: Not Found plowshare.noarch: W: spelling-error Summary(en_US) downloader -> downloaded, down loader, down-loader plowshare.noarch: W: spelling-error Summary(en_US) uploader -> unloader, uploaded, up loader plowshare.noarch: W: summary-not-capitalized C command-line downloader/uploader for some of the most popular file-sharing websites plowshare.noarch: E: summary-too-long C command-line downloader/uploader for some of the most popular file-sharing websites plowshare.noarch: W: spelling-error %description -l en_US downloader -> downloaded, down loader, down-loader plowshare.noarch: W: spelling-error %description -l en_US uploader -> unloader, uploaded, up loader plowshare.noarch: E: non-executable-script /usr/share/plowshare/modules/2shared.sh 0644L /bin/bash plowshare.noarch: E: non-executable-script /usr/share/plowshare/modules/mediafire.sh 0644L /bin/bash plowshare.noarch: E: non-executable-script /usr/share/plowshare/modules/depositfiles.sh 0644L /bin/bash plowshare.noarch: E: non-executable-script /usr/share/plowshare/modules/zshare.sh 0644L /bin/bash plowshare.noarch: E: non-executable-script /usr/share/plowshare/modules/megaupload.sh 0644L /bin/bash plowshare.noarch: E: non-executable-script /usr/share/plowshare/modules/rapidshare.sh 0644L /bin/bash plowshare.noarch: E: non-executable-script /usr/share/plowshare/modules/badongo.sh 0644L /bin/bash plowshare.noarch: E: non-executable-script /usr/share/plowshare/modules/4shared.sh 0644L /bin/bash plowshare.noarch: E: non-executable-script /usr/share/plowshare/lib.sh 0644L /bin/bash plowshare.noarch: W: no-manual-page-for-binary plowup plowshare.noarch: W: no-manual-page-for-binary plowdown plowshare.noarch: W: no-manual-page-for-binary plowdel 2 packages and 0 specfiles checked; 11 errors, 14 warnings. It seems that the source is a quite old version of the software (date of the initial review request). I picked it for review without actually checking what this software is. I guess nobody picked it yet because its use can be controversial. Anyway, let's ignore that aspect which does not matter for a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review