Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517191 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #28 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2011-01-13 16:27:50 EST --- OK, let me try to get this taken care of, then. (It's the second oldest untaken review ticket, and I'm tired of seeing it on the list.) Building is really noisy and installing in a fresh system is pretty noisy as well, though I expect it's due to some PHP issue or something weird about my local mock setup: PHP Warning: date(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected 'America/Chicago' for 'CST/-6.0/no DST' instead in /usr/share/pear/PEAR/Registry.php on line 1012 with a stack trace any time PHP gets called at all. Since nobody else has complained of this I suspect I'm the only one seeing it. The source in the srpm differs from the tarball I get from the upstream web site. I note that this spec manages to break vim's highlighting so everyhing after the first sed call in %install turns up pinkish-purple. I guess it's the escaped single quotes in those sed lines. So, outside of the oddity with the tarball, I think this is OK. X source files do not match upstream. sha256sum: 40afb5979abf1e06ce559e11a587ab61c8ad079a61fb32cfb65a37025cf586a4 symfony-1.4.8.tgz (downloaded) 58f71c2b8f7e72573a25d67f2b9af7af5536f873a98e8e74d9b6a8e9dddbe458 symfony-1.4.8.tgz (in package) * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: php-pear(pear.symfony-project.com/symfony) = 1.4.8 php-symfony-symfony = 1.4.8-1.fc15 = /bin/sh /usr/bin/env /usr/bin/pear php >= 5.2.4 php-channel(pear.symfony-project.com) php-doctrine-Doctrine >= 1.2.0 php-dom php-pear(PEAR) php-pear(pear.swiftmailer.org/Swift) >= 4.0.5 php-pear-phing >= 1.0.0 php-simplexml * no bundled libraries (as far as I can tell). * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files. * scriptlets are OK (pear module registration). * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review