Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-urljr - A common interface to urllib2 and curl for making HTTP requests https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218831 mr.ecik@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From mr.ecik@xxxxxxxxx 2006-12-08 13:09 EST ------- MUST items: * rpmlint is quiet * package is named well * spec file name is good * package meets Packaging Guidelines * package is licensed with an LGPL open-source compatible license * License field in spec file matches actual license * license file isn't included in %doc * md5sums are matching (0b120d08dc4538ed5c4ee5c77447b865) * BuildRequires listed well * no locales * no need to %post and %postun sections * not relocatable * package owns directories well * no duplicates in %files * %files section includes %defattr * proper %clean section * macros used well In fact, license file isn't included as a COPYING file contains only information about license, not the license itself. However, guidelines say that: "If (and only if) the source package includes the text of the license(s) in its wn file, then that file, containing the text of the license(s) for the package must be included in %doc." so it's not a blocker. Package is approved :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review