Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655496 --- Comment #6 from Mat Booth <fedora@xxxxxxxxxxxxxx> 2011-01-13 11:34:12 EST --- Ok, a quick look shows the following needs to be corrected: * Licence is incorrect, it should be GPLv2+ according the distributed licence and source file headers. * Unless you plan on participating in EPEL5, the BuildRoot tag is obsolete. EPEL6+ and Fedora 10+ ignore it entirely and it may be removed. * There is no require for "Requires: %{name}" in the javadoc sub-package. This should be removed. * In the recently approved new Java guidelines, we no longer should be shipping versioned jars or javadocs, so please drop the symlinks and install everything without the %{version} suffix. * A %clean section containing only "rm -rf $RPM_BUILD_ROOT" is no longer needed (except perhaps if you intend on participating in EPEL5) and should be removed * Please reduce the spelling errors that rpmlint complains about where you can. Change "javadocs" to "javadoc" and change "cheesey" to "cheesy". The rest really should be in the dictionary, so I'm willing to overlook them. Also, if you wish you may put the accent aigu "Ã" in your name in the change log -- you are allowed to submit UTF-8 encoded spec files. :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review