Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=669407 --- Comment #3 from Jiri Moskovcak <jmoskovc@xxxxxxxxxx> 2011-01-13 11:16:16 EST --- (In reply to comment #2) > I guess it was because of the "already existing dead project" with ledctl name > on sourceforge. > Personally, I think we could keep the package as ledctl (with %setup -n) ... > but if Jirka tends to rename the package, I'm not against it. > Actually I can live with ledctl using ledmon as source, but I would prefer to rename it (I was just too fast and upstream found out that ledctl is taken :( ) > Few notes before real rereview: > Please remove the note about missing upstream URL, URL is now provided. > - will do > You moved ledctl from %_bindir to %_sbindir - is that intentional?... - yes, it's an upstream change > it may > break some scripts if someone already started with the %_bindir (I know, it is > VERY low probability, but possibly some wrapper with deprecation warning could > be considered). - I built it only for rawhide so far, so I think we're safe... So the question is: Rename or not? Opinions? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review