[Bug 652546] Review Request: erlang-webmachine - A REST-based system for building web applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652546

--- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2011-01-13 09:12:35 EST ---
Thanks for the comments!

(In reply to comment #3)
>  +:ok, =:needs attention, -:needs fixing
> 
> MUST Items:
> [=] MUST: rpmlint must be run on every package.
> Rpmlint shows that the package contains no binary.
> Are the *.beam files architecture dependent ?
> If not then you should use BuildArch: noarch

Unfortunately I can't, and that's an Erlang-specific issue. 

All Erlang packages must be installed into Erlang's own libdir (
%{_libdir}/erlang/lib ) which is arch-dependent (thus every package effectively
becomes arch-dependent). I plan to eliminate this shortcoming in the future
Fedora releases, but I wouldn't expect quick resolution (maybe in Fedora 17 or
even in Fedora 18).

> [=] MUST: The sources used to build the package must match the upstream source,
>           as provided in the spec URL.
> https://fedoraproject.org/wiki/Packaging/SourceURL says:
> There are several cases where upstream is not providing the source to you in an
> upstream tarball.
> In these cases you must document how to generate the tarball used in the rpm
> either through
> a spec file comment or a script included as a separate SourceX:. 
> 

Done. Fixed comment, right above Source0.

Here are the latest spec and src.rpm files:

http://peter.fedorapeople.org/erlang-webmachine.spec
http://peter.fedorapeople.org/erlang-webmachine-1.8.0-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]