Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668243 --- Comment #4 from Fabio Massimo Di Nitto <fdinitto@xxxxxxxxxx> 2011-01-13 05:33:15 EST --- (In reply to comment #1) > Question: > libqb does have tests that can run as a part of "make check". > Is "make check" run as a part of the normal rpm creation? > If so, is it desirable to run these as a part of building the rpm? > > I would need to add: > BuildRequires: ... check-devel I see no reason not to run the make test at build time and check-devel is only a BuildRequires that would not clutter the final rpm with extra dependencies. So please turn on make check in the build. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review