Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646608 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #3 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2011-01-11 14:09:09 EST --- Good: + Basename of the SPEC file matches to package name + Package fullfill naming guidelines + Package contains most recent stable release of the application + Pakckage contains a valid license tag + License tag states GPLv2+ as a valid OSS license + Package contains a verbatin copy of the license text + Package contains no subpackages + Could download upstream tarball via spectool -g + Package tar ball matches with upstream (md5sum: 603aec311fdf709dc9dbeef917284116) + consistantly usage of rpm macros + Local build works fine + Scatch build works fine on koji + All package files are own by the package + All files has proper file permission + %doc stanza is small, so no separate doc sub package is required + package has proper chagelog entries Bad: - Package should contains Provides: %{name} = %{version}-%{release} - Rpmlint has the following complaints on the binary package: rpmlint drupal6-service_links-6.x.2.0-2.fc14.noarch.rpm drupal6-service_links.noarch: W: spelling-error %description -l en_US icio -> icily, icing, icicle drupal6-service_links.noarch: W: spelling-error %description -l en_US gnolia -> magnolia, goliard, Goliath drupal6-service_links.noarch: W: obsolete-not-provided drupal-service_links 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Please Check: ? Rpmlint has complaints on source package: rpmlint drupal6-service_links-6.x.2.0-2.fc14.src.rpm drupal6-service_links.src: W: spelling-error %description -l en_US icio -> icily, icing, icicle drupal6-service_links.src: W: spelling-error %description -l en_US gnolia -> magnolia, goliard, Goliath drupal6-service_links.src: W: strange-permission service_links-6.x-2.0.tar.gz 0444L drupal6-service_links.src:29: W: macro-in-comment %patch0 1 packages and 0 specfiles checked; 0 errors, 4 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review