Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vimoutliner - set of vim macros for editing outlines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217836 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-12-08 09:37 EST ------- A quick glance at your spec file and.... * Please specify all sources. * cp -f %{SOURCE5} README.Fedora - Use 'cp -p -f' to keep timestamp. * Why does this package call "update-desktop-database" though no desktop file is included? * helpztags %{_datadir}/vim/vimfiles/doc - What does this do? = If this script creates some files, the files (created by helpztags) should be included in this package with marked as %ghost %verify(not md5 size mtime), for example. = If this script changes some files included in this package, the files to be modified should marked with %verify(...) = If this script changes some files included in other packages, it shouldn't unless the files are marked with %verify(not ...) or %config or so. * %preun helpztags %{_datadir}/vim/vimfiles/doc - What does this do? At %preun stage, all files in this package still exist, so I think this does nothing (though I don't know what helpztags actually does......) By the way, does any sponsor watching this? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review