[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668591

Jeffrey Ness <jeffrey.ness@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeffrey.ness@xxxxxxxxxxxxx

--- Comment #1 from Jeffrey Ness <jeffrey.ness@xxxxxxxxxxxxx> 2011-01-11 13:23:33 EST ---
Hello Steve,

This is unofficial as I am not yet sponsored, however below are a few things I
noticed.

While attempting to build this package with mock using epel-5-i386 I received
some issues:

running install_scripts
+ rm -rf
'/var/tmp/python26-markupsafe-0.11-2.el5-root-mockbuild//usr/lib64/python2.6/site-packages/markupsafe/*.c'
+ chmod 755
/var/tmp/python26-markupsafe-0.11-2.el5-root-mockbuild//usr/lib64/python2.6/site-packages/markupsafe/_speedups.so
chmod: cannot access
`/var/tmp/python26-markupsafe-0.11-2.el5-root-mockbuild//usr/lib64/python2.6/site-packages/markupsafe/_speedups.so':
No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.12050 (%install)

running install_scripts
+ chmod 755
/var/tmp/python26-markupsafe-0.11-2.el5-root-mockbuild//usr/lib64/python2.6/site-packages/markupsafe/_speedups.so
chmod: cannot access
`/var/tmp/python26-markupsafe-0.11-2.el5-root-mockbuild//usr/lib64/python2.6/site-packages/markupsafe/_speedups.so':
No such file or directory
--

The problems seems to be due to explicitly setting python26_sitearch to lib64:

  %global python26_sitearch /usr/lib64/python2.6/site-packages

I would suggest being a bit less strict (or specifying the buildarch), below is
the macro I normally use for python_sitearch
(http://fedoraproject.org/wiki/Packaging:Python#Macros): 

%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

--

Another thing I noticed is in your %files you own everything in the path by
this package:

%{python26_sitearch}/*

Please be more specific here as you do not wish to list files owned by other
packages in yours:

%{python26_sitearch}/markupsafe/
%{python26_sitearch}/MarkupSafe-0.11-py2.6.egg-info/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]