Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652616 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-11 08:28:38 EST --- (In reply to comment #3) > Actually, I personally prefer to list them in this way :). That's OK. The package looks fine to me now. Just two minor notes (no blockers though): - You can drop Requires: erlang-stdlib as it's a dependency of erlang-erts. This would also remove the rpmlint error below. - it would be nice if upstream could add the texts of the involved licenses (CPL, ASL 2.0) $ rpmlint /var/lib/mock/fedora-14-i386/result/*.rpm erlang-ebloom.i686: E: explicit-lib-dependency erlang-stdlib erlang-ebloom.i686: W: no-documentation erlang-ebloom.src: W: invalid-url Source0: basho-ebloom-ebloom-1.0.2-0-g0d070d8.tar.gz 3 packages and 0 specfiles checked; 1 errors, 2 warnings. - the error "explicit-lib-dependency" is false positive but can be avoided by dropping Requires: erlang-stdlib - the missing doc warning is expected and no blocker --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - C sources of filter algorithm: CPL - NIF wrapper code: ASL 2.0 [+] MUST: The License field in the package spec file must match the actual license. [.] MUST: The file containing the text of the license(s) for the package must be included in %doc. - no license files present [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum basho-ebloom-ebloom-1.0.2-0-g0d070d8.tar.gz* cf6f766679ce10ad9d42e78090979f27 basho-ebloom-ebloom-1.0.2-0-g0d070d8.tar.gz cf6f766679ce10ad9d42e78090979f27 basho-ebloom-ebloom-1.0.2-0-g0d070d8.tar.gz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. koji scratch build (f14): http://koji.fedoraproject.org/koji/taskinfo?taskID=2714702 [.] MUST: If the package does not successfully compile, build or work ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [.] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix ... [.] MUST: devel packages must require the base package [+] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [X] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. - seems to work properly [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) should be placed in a -devel pkg. [+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [.] SHOULD: your package should contain man pages for binaries/scripts. ---------------- Package APPROVED ---------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review