Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652616 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |martin.gieseking@xxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |martin.gieseking@xxxxxx Flag| |fedora-review? --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-10 15:59:13 EST --- I take this one. If you like, I'd appreciate a review of the tiny xqc package (bug #655866) :) Some initial comments: - The binary package provides the erlang extension library ebloom_nifs.so. Is this library supposed to be accessible by other external applications too? If not, I suggest to filter it from the provides list as described in http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering - you can simplify the %files section by replacing all file/dir lines with the single line %{_libdir}/erlang/lib/%{realname}-%{version}/ But that's optional and a matter of personal preference -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review