Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598688 --- Comment #8 from Niels de Vos <ndevos@xxxxxxxxxx> 2011-01-10 14:47:32 EST --- Thanks Fabian! (In reply to comment #7) > Just some quick comments: > > - Man pages doesn't need %doc Fixed. > - You can use the name macro (%{name}) instead of the application name. Make > sometimes the maintenance easier Thanks for the pointer, but I prefer keeping the name as that is a little more readable. > - Please preserve the time stamps when possible > (https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps). Fixed. The updated .spec and SRPM can be downloaded here: - http://nixpanic.net/software/packages/archivemount - http://nixpanic.net/software/packages/archivemount/archivemount.spec - http://nixpanic.net/software/packages/archivemount/archivemount-0.6.1-2.fc14.src.rpm $ rpmlint archivemount.spec ~/rpmbuild/SRPMS/archivemount-0.6.1-2.fc14.src.rpm archivemount.src: W: spelling-error Summary(en_US) filesystem -> file system, file-system, systematic archivemount.src: W: spelling-error %description -l en_US libarchive -> lib archive, lib-archive, archive archivemount.src: W: spelling-error %description -l en_US gz -> g, z, gaz archivemount.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic 1 packages and 1 specfiles checked; 0 errors, 4 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review