Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637352 --- Comment #9 from GermÃn Racca <gracca@xxxxxxxxx> 2011-01-09 04:12:41 EST --- (In reply to comment #6) > Also, from the Packaging Guidelines: > > MUST: Packages containing GUI applications must include a %{name}.desktop file, > and that file must be properly installed with desktop-file-install in the > %install section. If you feel that your packaged GUI application does not need > a .desktop file, you must put a comment in the spec file with your explanation. > > Which does not seem the case for this package. > > I also encountered a problem building with upstream g++ using -march=i386, > although i386 is probably obsolete nowadays (the issue was about undefined > references to `__sync_fetch_and_add_4', which is a somewhat known issue, don't > know about g++ shipped with Fedora). Please, are you interested in doing a complete review? If so, I will follow your suggestions :) Regards, German. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review