Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663914 Michal Fojtik <mfojtik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #3 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2011-01-07 04:34:45 EST --- ==== Package approved by mfojtik ===== Some notes, please fix that before you import this package to Fedora packages: * Requires: rubygem(rspec) >= 0 I'm not sure, if >=0 is required here. You can use just rubygem(rspec) * %{geminstdir}/fssm.gemspec Please replace 'fssm' with macro you defined at the top %gemname Format review: [OK] Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification. [OK] The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version [OK] The package must have a Requires and a BuildRequires on rubygems [OK] The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification. [OK] For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem [OK] The %prep and %build sections of the specfile should be empty. [OK] The Gem must be installed into %{gemdir} defined as %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) [OK] The package must own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec [OK] If the Gem only contains pure Ruby code, it must be marked as BuildArch: noarch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review