Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #10 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2011-01-06 16:55:49 EST --- (In reply to comment #7) > * TODO: python2-devel is now preferred to python-devel. > https://fedoraproject.org/wiki/Packaging:Python#BuildRequires AFAIK python-devel is a virtual provides that always defaults to the perferred version of python. IMHO we should not hardcode a specific version. > * I hope you can convince upstream to rid of gtk requirement from setup.py. It > should be an easy job. > > > This package will be approved when the two last issues fixed. Are you blocking this review for an issue with the upstream code that can be easy worked around? I have contacted upstream and sent him the patch, but if he doesn't accept it I will not use it because of our commitment to upstream. Nevertheless this should not block a review. It's a package review and not a code review and as long as there are no security issues or severe bugs, this should not be considered a blocker I think. (In reply to comment #9) > This package uses glade mechanism, you'd better add pygtk2-libglade to > requirement. You don't need to have pygtk2-libglade installed to run cherrytree. (In reply to comment #8) > But I would suggest to not install into %{python_sitelib}, because upstream > (and so othere distributions don't do that too, but your choice ;-) Fine with me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review