Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579925 --- Comment #4 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2011-01-06 14:41:53 EST --- I guess the primary question is why you would want to push unmaintained software into the distribution when by your own admission you aren't sufficiently familiar with the software to maintain it if problems arise. For example, what happens if Fedora updates to a readline version which is no longer ABI compatible? As to the package itself, I think it looks fine assuming you intend to push this to EL4 or EL5; otherwise you can drop several bits. I'm not sure why you apply memuse.patch; did our tcl become threaded at some point? (I guess it doesn't really hurt anything, but generally you patch to fix something that's actually broken.) prompt2.patch seems too actually change the API of the library. Are you really sure you didn't intend to fork this software? Debian policies may permit this kind of thing but it's really a bad idea. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review