Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667226 Volker FrÃhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker FrÃhlich <volker27@xxxxxx> 2011-01-06 12:26:27 EST --- Some initial comments: The license seems to be GPLv3+: * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * as published by the Free Software Foundation; either version 3 * of the License, or (at your option) any later version. Please don't put all the Build Requires in one line, since it's not very clear. There is no package called lastfmlib-devel in Fedora. The name should be liblastfm-devel and the package doesn't build for me. The source also contains a copy of qtx. Please make sure it isn't used. Maybe delete it. I noticed, the player also works with MySQL. Does that need any preparation? Please don't mix $RPMBUILDROOT and %{buildroot} -- simply opt for one. I guess, a full stop can replace %{_builddir}/%{name}-%{version} from the cmake call. /usr should be %{_prefix}, but first check, if they are all necessary. Please use %{_datadir}, to substitute for /usr/share -- also in the files section. The category list in the desktop file should terminate in a semicolon (desktop-file-validate). Probably put the %doc first in the files section (after %defattr). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review