Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664812 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-01-06 05:31:34 EST --- Source tar ball is original. Ok. Summary verified from lib/HTML/Quoted.pm. Ok. License verified from lib/HTML/Quoted.pm. Ok. Description copied from Summary because there is no better. Ok. TODO: Add full stop on the end of Description. You can use %{summary} macro to refer the text. FIX: BuildRequire perl(Data::Dumper) (t/lines.t) as it can dual-live in the future (http://search.cpan.org/~smueller/Data-Dumper/) All tests pass. Ok. $ rpmlint perl-HTML-Quoted.spec ../SRPMS/perl-HTML-Quoted-0.02-1.fc14.src.rpm ../RPMS/noarch/perl-HTML-Quoted-0.02-1.fc14.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint Ok. $ rpm -pqlv ../RPMS/noarch/perl-HTML-Quoted-0.02-1.fc14.noarch.rpm drwxr-xr-x 2 root root 0 led 6 11:08 /usr/share/doc/perl-HTML-Quoted-0.02 -rw-r--r-- 1 root root 94 Ãno 27 2010 /usr/share/doc/perl-HTML-Quoted-0.02/Changes -rw-r--r-- 1 root root 252 Ãno 27 2010 /usr/share/doc/perl-HTML-Quoted-0.02/README -rw-r--r-- 1 root root 1865 led 6 11:08 /usr/share/man/man3/HTML::Quoted.3pm.gz drwxr-xr-x 2 root root 0 led 6 11:08 /usr/share/perl5/HTML -rw-r--r-- 1 root root 6604 Ãno 27 2010 /usr/share/perl5/HTML/Quoted.pm File permissions and layout Ok. $ rpm -pq --requires ../RPMS/noarch/perl-HTML-Quoted-0.02-1.fc14.noarch.rpm |sort |uniq -c 1 perl(base) 1 perl(:MODULE_COMPAT_5.12.2) 1 perl(strict) 1 perl(warnings) 1 perl >= 0:5.008 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 FIX: Require perl(HTML::Parser) >= 3.0 (lib/HTML/Quoted.pm:40, META.yml:22) $ rpm -pq --provides ../RPMS/noarch/perl-HTML-Quoted-0.02-1.fc14.noarch.rpm |sort |uniq -c 1 perl(HTML::Quoted::Parser) 1 perl(HTML::Quoted) = 0.02 1 perl-HTML-Quoted = 0.02-1.fc14 Binary provides Ok. $ resolvedeps-f15 ../RPMS/noarch/perl-HTML-Quoted-0.02-1.fc14.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2704263). Ok. Otherwise package is in line with Fedora and perl packaging guide lines. Please correct all `FIX' prefixed issues and submit new spec file. Please consider fixing all `TODO' issues. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review