Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596138 --- Comment #9 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2011-01-05 16:18:30 EST --- Just noticed this when going over old review tickets. Perhaps I can answer a few questions: The package can still be included in the Fedora 14 repositories; we won't stop that for quite some time yet. Reviews are mostly about packaging, but the process does not entirely bypass all consideration of the software itself. For example, it is important that it actually work and not open up massive security holes. Even though it's a small package, it still needs a bit of work. Did you ever run rpmlint over the srpm and resulting binary rpms? It's expected that you do so. nss-gui.x86_64: W: no-documentation nss-gui.x86_64: W: no-manual-page-for-binary nss-gui It might be nice to have some documentation. It would also be nice to have some indication of the license. nss-gui-debuginfo.x86_64: E: debuginfo-without-sources This generally indicates a build problem and indeed it seems that the compiler is not being called with the proper flags. You'll need to figure out how to pass %optflags or $RPM_OPT_FLAGS. Looks like this will involve Makefile patching as the included makefile doesn't seem to pay attention to anything. The use of macros in the spec is inconsistent. Generally you should just not use %{__rm} and such unless for some reason you really like pointless typing, but if you really do want to use those macros then you also need to use %{__cp} and %{__make} and such. The description could use a bit less cryptic, I think. If this is end-user software then some additional explanation is warranted. Perhaps that's why you haven't attracted any reviewers; they can't figure out what it's supposed to do. The software doesn't seem to work for me. I built in mock for x86_64 rawhide and installed it on a rawhide VM; nss-gui fails to start: Error: Platform version '2.0b7' is not compatible with minVersion >= 1.9 maxVersion <= 1.9.2.* At the least that indicates that some dependencies are off. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review